Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cache, model): add max_stage_video_channel_users #2152

Merged
merged 2 commits into from
Sep 15, 2024
Merged

feat(cache, model): add max_stage_video_channel_users #2152

merged 2 commits into from
Sep 15, 2024

Conversation

zeylahellyer
Copy link
Member

@zeylahellyer zeylahellyer commented Feb 17, 2023 •
edited
Loading

Add support for the guild field max_stage_video_channel_users, which functions similarly to related fields such as max_video_channel_users. This has been added on the Guild model type and the CachedGuild inmemory cache type.

Split out from #2147.

@zeylahellyer zeylahellyer added c-cache Affects the cache crate c-model Affects the model crate d-api Change related to Discord's API. d-not-deployed Discord API change that hasn't been deployed to the docs. w-do-not-merge PR is blocked or deferred labels Feb 17, 2023
@github-actions github-actions bot added the t-feature Addition of a new feature label Feb 17, 2023
@zeylahellyer zeylahellyer mentioned this pull request Feb 17, 2023
Merged
@zeylahellyer zeylahellyer marked this pull request as draft February 17, 2023 03:51
@Gelbpunkt Gelbpunkt marked this pull request as ready for review November 24, 2023 22:40
@Gelbpunkt
Copy link
Member

This change has been deployed to the public API documentation and we should try to get this merged, possibly after #2179.

@Gelbpunkt Gelbpunkt removed d-not-deployed Discord API change that hasn't been deployed to the docs. w-do-not-merge PR is blocked or deferred labels Nov 24, 2023
HTGAzureX1212
HTGAzureX1212 approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Conflicts should be resolved before this can be merged.

laralove143
laralove143 reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@laralove143 laralove143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but do we consider this a breaking change because it adds a field to guild which can be constructed with a struct literal

@suneettipirneni @Gelbpunkt
feat(cache, model): add max_stage_video_channel_users
1afb26a 
Add support for the guild field `max_stage_video_channel_users`, which
functions similarly to related fields such as `max_video_channel_users`.
This has been added on the `Guild` model type and the `CachedGuild`
inmemory cache type.
@Gelbpunkt Gelbpunkt force-pushed the zeyla/feat-cache-model-max_stage_video_channel_users branch from 5fd52dc to 1afb26a Compare September 9, 2024 21:07
@Gelbpunkt Gelbpunkt merged commit 8035434 into main Sep 15, 2024
9 checks passed
@Gelbpunkt Gelbpunkt deleted the zeyla/feat-cache-model-max_stage_video_channel_users branch September 15, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laralove143 laralove143 laralove143 left review comments

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

@Gelbpunkt Gelbpunkt Gelbpunkt approved these changes

Assignees
No one assigned
Labels
c-cache Affects the cache crate c-model Affects the model crate d-api Change related to Discord's API. t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeylahellyer @Gelbpunkt @HTGAzureX1212 @laralove143 @suneettipirneni